Make cinder volume HA work again#827
Merged
dirkmueller merged 1 commit intocrowbar:masterfrom Feb 3, 2017
Merged
Conversation
dirkmueller
force-pushed
the
cinder_volume_ha
branch
4 times, most recently
from
3eaf3ae to
809b53b
Compare
Contributor
s-t-e-v-e-n-k
left a comment
s-t-e-v-e-n-k
left a comment
There was a problem hiding this comment.
This change will break the cinder volume migration script, which looks for the cluster hostname set in the cinder-volume configuration directly.
Contributor
Author
|
Ah, so that script.is broken already.. when we cherry pick only the first commit then that would make it work agsin. Can you adjust the script? It doesn't look bery robust |
aplanas
approved these changes
Feb 3, 2017
The thing here is that for volume HA, either backend_host needs to be set in the *backend* *xor* *host* needs to be set only for cinder-volume service. What this change however did was changing the DEFAULT group host parameter to the nonexisting backend_host parameter, which effectly completely disabled volume HA. This reverts commit e533d4e.
dirkmueller
force-pushed
the
cinder_volume_ha
branch
from
809b53b to
0984589
Compare
toabctl
approved these changes
Feb 3, 2017
Contributor
Author
|
ok, I moved the breaking cleanup change into a separate pull request, #828 so this one should be good to go. it will actually fix the volume migration script issue that @s-t-e-v-e-n-k pointed out as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately as part of the Hyper Agile Super config rediffing effort the feature was accidentally disabled. Revert the incorrect change and switch to a more robust implementation that does not suffer from deprecation warnings .